On Wed, 2010-05-26 at 00:54 +0200, Gábor Stefanik wrote: > >> - if (wdev) > >> - wdev->channel = chan; > >> + wdev = old_wdev; > >> + wdev->channel = chan; > > > > NACK. That will crash when there really is no interface being passed in. > > > > johannes > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > Well, the original version already dereferences wdev in "if > (wdev->iftype...", so the crash is nothing new if it exists. It has also been fixed since. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html