Johannes Berg wrote:
On Wed, 2010-05-26 at 00:54 +0200, Gábor Stefanik wrote:
- if (wdev)
- wdev->channel = chan;
+ wdev = old_wdev;
+ wdev->channel = chan;
NACK. That will crash when there really is no interface being passed in.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Well, the original version already dereferences wdev in "if
(wdev->iftype...", so the crash is nothing new if it exists.
It has also been fixed since.
Is someone porting this fix into wireless-testing and stable or does
that still need to be done? Fixed channel of -1 is sort of an issue for
using monitor mode....
Thanks,
Rick
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
