2010/4/26 John W. Linville <linville@xxxxxxxxxxxxx>: > On Mon, Apr 26, 2010 at 02:04:03PM -0500, Larry Finger wrote: >> On 04/26/2010 01:33 PM, Rafał Miłecki wrote: >> > 2010/4/26 John W. Linville <linville@xxxxxxxxxxxxx>: > >> >> FWIW, this patch series also still results in a hang on my problematic >> >> netbook. I'm going to merge them anyway, in hopes that they make >> >> things better for someone (or at least get us closer to it). I'll try >> >> to pinpoint this hang as well. >> > >> > Did it actually pick another (newly discovered) offset for SPROM >> > location in your case? Could you add some single printk to check this? >> >> My suggestion is that for now we only implement John's patch for no >> SPROM. I am hoping that we try to fix the failures for boxes with the >> SPROM in a normal location. Once we do that, there will be a simpler fix >> for testing at the alternate location. The patch will all be contained >> in sprom_do_read(). > > Hmmm...well, I just pushed (just to my public trees, not to Dave) > Rafał's trio of patches on top of mine. Should I revert them? AFAIU so far we didn't have any confirmation that it actually fixes anything. Don't know... maybe it would be better to wait for any successful feedback? I don't 100% know patches rules, let you decide. In case we decide to implement that letter, it should be easy to rebase patches. > P.S. With those patches, this box (soon to be Larry's) still uses > an sprom_offset value of 0x1000. Hm, so it looks like you device doesn't match our "if (version)" condition... It's just a blind guess, but maybe it would be worth to *force* other SPROM location on your machine? It seems quite proven that reading some incorrect registers (in this case incorrect SPROM location) can cause lock up. Of course it's just my guess, assuming you have other SPROM location, lock up is caused by reading wrong register and that Larry's condition in incorrect/not full. However if you're gonna to send whole machine to Larry, it sounds worthy to check this trick. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
