Ming Lei wrote: > The skb->data is passed into usb hcd and usb hcd will do dma mapping > for the buffer of skb->data, so it is better to keep it cache-line aligned. > > Size of cache line is very cpu dependent, we can't suppose it is > 32byte(NET_SKB_PAD) aligned, 64byte or more is very possible. Hm. Indeed, using alloc_skb() is right in this case, since we reuse the same RX buffer and never pass it on to mac80211 directly. Instead, new SKBs are formed from the stream and sent to mac80211. So yes, it makes sense to use alloc_skb() instead of dev_alloc_skb(). A small nitpick: It would be a bit clearer if you can use kfree_skb() instead of dev_kfree_skb_any() in the corresponding places. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
