Search Linux Wireless

[PATCH 3/3] ath9k-htc: pass cacheline aligned buffer to usb hcd in register out path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tom.leiming@xxxxxxxxx wrote:
> This patch copies skb->data of register out command to kmalloced buffer,
> which is cacheline aligned(dma safe) and passed into usb hcd. Since the
> data in register out command is not very much, we can ignore the
> performance loss caused by the copy.

Actually, the current code is correct, though a bit sub-optimal.
The inital dev_alloc_skb() in ath9k_wmi_cmd() allocates a headroom
for WMI header + HTC header. The headers are then pushed as the packet
moves down through HTC. Finally, skb->data is passed to submit_urb().

To take care of cacheline alignment, you can just replace the dev_alloc_skb()
with alloc_skb(). A patch is welcome. :-)

Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux