On Mon, 2010-03-29 at 09:17 +0200, Stanislaw Gruszka wrote: > On Fri, Mar 26, 2010 at 10:26:03AM -0700, Johannes Berg wrote: > > > void ieee80211_sta_def_wmm_params(struct ieee80211_sub_if_data *sdata, > > > @@ -816,7 +824,7 @@ void ieee80211_sta_def_wmm_params(struct ieee80211_sub_if_data *sdata, > > > else > > > sdata->flags &= ~IEEE80211_SDATA_OPERATING_GMODE; > > > > > > - ieee80211_set_wmm_default(sdata); > > > + ieee80211_set_wmm_default(sdata, true); > > > > Shouldn't that be false though? > > I think so, I did like that just to not change old behaviour (on iwlwifi). > > But I think also, that all ieee80211_set_wmm_default function calls > should be with false, in other words, we should disable QoS in > ieee80211_set_wmm_default(). > > What is your opinion? Yeah that seems right to me, if we're going to set to the default then that should probably mean off, even if we do configure the queues. I'm just not exactly sure how AP should be handled wrt. turning QoS on, probably on the first queue config from userspace? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
