Search Linux Wireless

Re: [PATCH 1/2] mac80211: explicitly disable/enable QoS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-03-26 at 17:46 +0100, Stanislaw Gruszka wrote:

> + * QIEEE80211_CONF_QOS: Enable 802.11e QoS also know as WMM (Wireless
      ^ typo

> +
> +	/* activate new settings */
> +	if (wmm_on)
> +		local->hw.conf.flags |=	IEEE80211_CONF_QOS;
> +	else
> +		local->hw.conf.flags &=	~IEEE80211_CONF_QOS;
> +
> +	drv_config(local, IEEE80211_CONF_CHANGE_QOS);

Ok, fair enough, we need to think this through in the multi-vif case
anyway.
 
>  void ieee80211_sta_def_wmm_params(struct ieee80211_sub_if_data *sdata,
> @@ -816,7 +824,7 @@ void ieee80211_sta_def_wmm_params(struct ieee80211_sub_if_data *sdata,
>  	else
>  		sdata->flags &= ~IEEE80211_SDATA_OPERATING_GMODE;
>  
> -	ieee80211_set_wmm_default(sdata);
> +	ieee80211_set_wmm_default(sdata, true);

Shouldn't that be false though?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux