Search Linux Wireless

Re: [PATCH 1/2] mac80211: explicitly disable/enable QoS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 26, 2010 at 10:26:03AM -0700, Johannes Berg wrote:
> >  void ieee80211_sta_def_wmm_params(struct ieee80211_sub_if_data *sdata,
> > @@ -816,7 +824,7 @@ void ieee80211_sta_def_wmm_params(struct ieee80211_sub_if_data *sdata,
> >  	else
> >  		sdata->flags &= ~IEEE80211_SDATA_OPERATING_GMODE;
> >  
> > -	ieee80211_set_wmm_default(sdata);
> > +	ieee80211_set_wmm_default(sdata, true);
> 
> Shouldn't that be false though?

I think so, I did like that just to not change old behaviour (on iwlwifi).

But I think also, that all ieee80211_set_wmm_default function calls
should be with false, in other words, we should disable QoS in
ieee80211_set_wmm_default().

What is your opinion?

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux