On Wed, Mar 24, 2010 at 09:13:53AM -0700, Johannes Berg wrote: > On Wed, 2010-03-24 at 10:37 +0100, Stanislaw Gruszka wrote: > > > > Why "disabled" btw, and not enabled? Everything else is usually done in > > > a positive sense here, I'd say. > > > > To emphasize we disable QoS as conf_tx enable it implicitly. > > Which I actually think should be changed in iwlwifi. No other driver > cares, and this has always been a bit of a mess there (in iwlwifi). Hmm, for example in mwl8k have mwl8k_cmd_set_wmm_mode(1)in conf_tx() as well. I think this is hardware/firmware requirement. > > In ideal case we want to change conf_tx to configure all queues > > or disable qos. But since this is exported to userspace additional > > disable_qos callback is the best implementation for me. > > Yes, that would be ideal, but the second best thing, and one that we can > do, would be to decouple configuring QoS and enabling/disabling QoS > completely, not do a jumbled-up implementation like you're suggesting? Since conf_tx enable QoS, and must do it, we need only interface to disable QoS. Decoupling just give us only more code, but since you require that, I will do it. If this must be called at initialization ieee80211_ops->config is better for that, I will use new ieee80211_conf->flags. Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
