On Tue, 2010-03-23 at 13:46 +0100, Stanislaw Gruszka wrote: > + * @qos_disabled: whether QoS (aka WMM) should be disabled or not Why "disabled" btw, and not enabled? Everything else is usually done in a positive sense here, I'd say. Also, the default would now be enabled, and I think this needs more work for AP mode. You're implementing generic API, don't fall into the trap of thinking it's only for iwlwifi's special case. So at least there it should be enabled if the hw supports it and the change flag should be set at least once. Also, your code sends a weird signal to hw that doesn't support QoS, it actually enables qos for it ... johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
