Search Linux Wireless

Re: [PATCH 2/2] iwlwifi: implement disabling/enabling QoS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2010-03-23 at 13:46 +0100, Stanislaw Gruszka wrote:
> Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>

This really could use "more" text as to why etc.

> +	if (changes & BSS_CHANGED_QOS) {
> +		unsigned long flags;
> +
> +		spin_lock_irqsave(&priv->lock, flags);
> +		priv->qos_data.qos_active = bss_conf->qos_disabled ? 0 : 1;
> +		iwl_activate_qos(priv, 1);
> +		spin_unlock_irqrestore(&priv->lock, flags);
> +	}

This seems alright, but we really need to revisit that since there's a
lot of odd logic in iwlwifi that makes some sense based on this now but
could probably be simplified now. I'll close with Wey-Yi, she worked on
QoS here at some point I think.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux