Hi Stanislaw,
On Tue, 2010-03-23 at 10:21 -0700, Johannes Berg wrote:
> On Tue, 2010-03-23 at 13:46 +0100, Stanislaw Gruszka wrote:
> > Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx>
>
> This really could use "more" text as to why etc.
>
> > + if (changes & BSS_CHANGED_QOS) {
> > + unsigned long flags;
> > +
> > + spin_lock_irqsave(&priv->lock, flags);
> > + priv->qos_data.qos_active = bss_conf->qos_disabled ? 0 : 1;
> > + iwl_activate_qos(priv, 1);
> > + spin_unlock_irqrestore(&priv->lock, flags);
> > + }
>
> This seems alright, but we really need to revisit that since there's a
> lot of odd logic in iwlwifi that makes some sense based on this now but
> could probably be simplified now. I'll close with Wey-Yi, she worked on
> QoS here at some point I think.
>
If I understand correctly, the current implementation has problem, by
just calling iwl_activate_qos(), it did not have the AC setup correctly,
take a look at the iwl_reset_qos(), it is the only place initialize the
table, for STA mode, QoS is de-active by default. iwl_activate_qos()
only change the qos flag, but did not re-initialize the table to proper
value.
Thanks
Wey
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
