Search Linux Wireless

Re: [PATCH 10/10] ath5k: Adaptive Noise Immunity (ANI) Implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bruno Randolf <br1@...> writes:
>  
> +/* debugfs: ani */
> +
> +static ssize_t read_file_ani(struct file *file, char __user *user_buf,
> +				   size_t count, loff_t *ppos)
> +{
> +	return simple_read_from_buffer(user_buf, count, ppos, buf, len);
...
> +}

I would prefer a machine readable solution, e.g. individual files
in an ANI directory with one value each.

> +static ssize_t write_file_ani(struct file *file,
> +				 const char __user *userbuf,
> +				 size_t count, loff_t *ppos)
> +{
...
> +	return count;
> +}

Same as above: instead of a catch all with magic configuration words, use
individual files with at least guessable values (e.g. 0/1 for enable/disable
of individual features).

Otherwise I'm excited to see ath5k become feature complete compared with 
Madwifi.

Regards
  Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux