On Wed, 2010-03-24 at 10:37 +0100, Stanislaw Gruszka wrote: > > Why "disabled" btw, and not enabled? Everything else is usually done in > > a positive sense here, I'd say. > > To emphasize we disable QoS as conf_tx enable it implicitly. Which I actually think should be changed in iwlwifi. No other driver cares, and this has always been a bit of a mess there (in iwlwifi). > In ideal case we want to change conf_tx to configure all queues > or disable qos. But since this is exported to userspace additional > disable_qos callback is the best implementation for me. Yes, that would be ideal, but the second best thing, and one that we can do, would be to decouple configuring QoS and enabling/disabling QoS completely, not do a jumbled-up implementation like you're suggesting? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
