On Wed, 2009-07-15 at 09:16 -0700, Luis R. Rodriguez wrote:
> On Wed, Jul 15, 2009 at 09:05:06AM -0700, Johannes Berg wrote:
> > On Wed, 2009-07-15 at 08:14 -0700, Luis R. Rodriguez wrote:
> > > > > + if (!(wiphy->wow_triggers_supported & triggers_requested)) {
> > > > > + err = -EOPNOTSUPP;
> > > > > + goto out;
> > > >
> > > > This seems wrong, should be "requested & supported != requested", I
> > > > think.
> > >
> > > The above one won't return -EOPNOTSUPP when you add additional junk, you're
> > > right, better to just inform userspace of that.
> >
> > Your version also disallows turning off WoW again, afaict.
>
> That is something we do want, as otherwise we'll keep the device powered on.
> Will consider both.
Huh? There has to be a way to turn off wow again after you've actually
resumed for other reasons, or whatever.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
