On Wed, 2009-07-15 at 08:14 -0700, Luis R. Rodriguez wrote:
> Will change it, thanks. I see NLMSG_DEFAULT_SIZE is smaller than
> NLMSG_GOODSIZE (it removes the NLMSG_HDRLEN), but no documentation
> for either, when should I use either?
I don't know, but GOODSIZE is larger than a page or something, iirc.
There was a patch recently changing all the users.
> > > + if (!(wiphy->wow_triggers_supported & triggers_requested)) {
> > > + err = -EOPNOTSUPP;
> > > + goto out;
> >
> > This seems wrong, should be "requested & supported != requested", I
> > think.
>
> The above one won't return -EOPNOTSUPP when you add additional junk, you're
> right, better to just inform userspace of that.
Your version also disallows turning off WoW again, afaict.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
