Search Linux Wireless

Re: [PATCH 3/5] cfg80211: add WoW support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2009-07-14 at 20:21 -0400, Luis R. Rodriguez wrote:

> +	/* Draw up a netlink message to send back */
> +	msg = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> +	if (!msg) {

Need to use DEFAULT_SIZE or something.

> +	if (!(wiphy->wow_triggers_supported & triggers_requested)) {
> +		err = -EOPNOTSUPP;
> +		goto out;

This seems wrong, should be "requested & supported != requested", I
think.

> @@ -4253,6 +4359,16 @@ static struct genl_ops nl80211_ops[] = {
>  	{
>  		.cmd = NL80211_CMD_DISCONNECT,
>  		.doit = nl80211_disconnect,
> +	},
> +	{
> +		.cmd = NL80211_CMD_GET_WOW,
> +		.doit = nl80211_get_wow,
> +		.policy = nl80211_policy,
> +		/* can be retrieved by unprivileged users */
> +	},
> +	{
> +		.cmd = NL80211_CMD_SET_WOW,
> +		.doit = nl80211_set_wow,
>  		.policy = nl80211_policy,
>  		.flags = GENL_ADMIN_PERM,
>  	},

This messes up the disconnect command.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux