On Wed, Jul 15, 2009 at 04:45:22AM -0700, Johannes Berg wrote:
> On Tue, 2009-07-14 at 20:21 -0400, Luis R. Rodriguez wrote:
>
> > + /* Draw up a netlink message to send back */
> > + msg = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
> > + if (!msg) {
>
> Need to use DEFAULT_SIZE or something.
Will change it, thanks. I see NLMSG_DEFAULT_SIZE is smaller than
NLMSG_GOODSIZE (it removes the NLMSG_HDRLEN), but no documentation
for either, when should I use either?
> > + if (!(wiphy->wow_triggers_supported & triggers_requested)) {
> > + err = -EOPNOTSUPP;
> > + goto out;
>
> This seems wrong, should be "requested & supported != requested", I
> think.
The above one won't return -EOPNOTSUPP when you add additional junk, you're
right, better to just inform userspace of that.
> > @@ -4253,6 +4359,16 @@ static struct genl_ops nl80211_ops[] = {
> > {
> > .cmd = NL80211_CMD_DISCONNECT,
> > .doit = nl80211_disconnect,
> > + },
> > + {
> > + .cmd = NL80211_CMD_GET_WOW,
> > + .doit = nl80211_get_wow,
> > + .policy = nl80211_policy,
> > + /* can be retrieved by unprivileged users */
> > + },
> > + {
> > + .cmd = NL80211_CMD_SET_WOW,
> > + .doit = nl80211_set_wow,
> > .policy = nl80211_policy,
> > .flags = GENL_ADMIN_PERM,
> > },
>
> This messes up the disconnect command.
Must have been a rebase issue, strange, thanks, will fix up.
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
