On Wed, 2009-07-15 at 08:22 -0700, Luis R. Rodriguez wrote: > On Wed, Jul 15, 2009 at 04:57:35AM -0700, Johannes Berg wrote: > > On Tue, 2009-07-14 at 20:21 -0400, Luis R. Rodriguez wrote: > > > If we're associated and have not already gone into PS mode > > > we ensure send a nullfunc frame before going to suspend. Upon > > > resume we ensure we restore PS mode if it was enabled and inform > > > the driver accordingly, also notify the AP we're awake. > > > > > > WoW requires the radio to be left on during suspend, to do this > > > we inform drivers of the requested wow triggers on the mac80211 > > > stop callback. > > > > I don't think this patch would work if ath9k unprogrammed the hardware > > correctly in ->remove_interface(), since you don't seem to skip that > > call. > > We just stop ANI in remove interface and reclaim beacon resources. > As per documentation it seems we are not correctly removing the MAC > address in ath9k for the removed interface to stop sending ACKs back. > I'd rather see that as a separate patch fix, but you do have a point. > As is right now though this doesn't affect WoW. You haven't understood my point -- it makes your WoW patch invalid because drivers that implement remove_interface properly cannot possibly implement WoW this way. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
