On Mon, 2009-05-11 at 23:16 +0100, Hin-Tak Leung wrote: > Argh, is this the reason why compat-wireless(wireless-testing?) today > doesn't quite work any more? > NetworkManager no longer wants to work, with this message in syslog: > > localhost NetworkManager: <WARN> nm_device_wifi_disable_encryption(): > error setting key for device wlan2: Invalid argument I don't think NM cares about the return value of this call. > and trying to do it by hand give this error: > > #iwconfig wlan2 key restrict <key> > Error for wireless request "Set Encode" (8B2A) : > SET failed on device wlan2 ; Invalid argument. Remove the "restrict", afaict we never supported that argument in mac80211. Anyway, I think there's a small bug when removing keys -- below patch should fix it. wpa_supplicant worked fine with my patch fwiw. johannes --- net/wireless/wext-compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- wireless-testing.orig/net/wireless/wext-compat.c 2009-05-12 08:29:02.000000000 +0200 +++ wireless-testing/net/wireless/wext-compat.c 2009-05-12 08:29:17.000000000 +0200 @@ -580,7 +580,7 @@ int cfg80211_wext_siwencode(struct net_d params.cipher = WLAN_CIPHER_SUITE_WEP40; else if (erq->length == 13) params.cipher = WLAN_CIPHER_SUITE_WEP104; - else + else if (!remove) return -EINVAL; return cfg80211_set_encryption(rdev, dev, NULL, remove, -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
