Subject: wext: remove seq_start/stop sparse annotations
Even though they are true, they cause sparse to complain
because it doesn't see the __acquires(dev_base_lock) on
dev_seq_start() because it is only added to the function
in net/core/dev.c, not the header file. To keep track of
the nesting correctly we should probably annotate those
functions publically, but for now let's just remove the
annotation I added to wext.
Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
---
I guess I should have actually run sparse... This could be part of the
wext locking fix "wext: fix get_wireless_stats locking" instead of being
standalone, if you're so inclined.
net/wireless/wext.c | 2 --
1 file changed, 2 deletions(-)
--- wireless-testing.orig/net/wireless/wext.c 2009-05-12 08:12:23.000000000 +0200
+++ wireless-testing/net/wireless/wext.c 2009-05-12 08:13:16.000000000 +0200
@@ -650,14 +650,12 @@ static int wireless_seq_show(struct seq_
}
static void *wireless_dev_seq_start(struct seq_file *seq, loff_t *pos)
- __acquires(dev_base_lock)
{
rtnl_lock();
return dev_seq_start(seq, pos);
}
static void wireless_dev_seq_stop(struct seq_file *seq, void *v)
- __releases(dev_base_lock)
{
dev_seq_stop(seq, v);
rtnl_unlock();
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
