On Mon, May 11, 2009 at 11:40 PM, Dan Williams <dcbw@xxxxxxxxxx> wrote: > On Mon, 2009-05-11 at 23:16 +0100, Hin-Tak Leung wrote: >> On Mon, May 11, 2009 at 3:09 PM, Johannes Berg >> <johannes@xxxxxxxxxxxxxxxx> wrote: >> > On Mon, 2009-05-11 at 09:50 -0400, Dan Williams wrote: >> > >> >> I modified the meaning of RESTRICTED/OPEN a few years ago to control the >> >> WEP auth mode, for a few reasons... First, some fullmac drivers already >> >> used it to mean WEP auth mode. Second, there was no other mechanism to >> >> control WEP auth mode at the time, and there were a lot of Shared Key >> >> installations around. Third, WE-18/WPA was nowhere near being landed, >> >> and it was only supported by one driver (hostap), and it was the only >> >> thing that would plausibly support WEP auth mode via SIWAUTH. Fourth, >> >> only hostap and maybe airo really implemented the refuse-non-encoded >> >> anyway. >> > >> > But didn't update the header file ;) >> > >> >> TBH, SK is nice because it tells you that the WEP key is wrong >> >> *immediately*, and the only reason NM doesn't use SK by default (and >> >> then fall back to OS) like the original Mac Airport drivers did is that >> >> WEXT simply cannot return reliable association error information. >> > >> > Hah. Well, we could have that now, but I suspect SK is no longer common >> > enough to put a lot of work into it. >> > >> >> But in the end, we still need a mechanism with WEXT to be able to set SK >> >> auth when associating. >> > >> > We still have that, with WE18, in IW_AUTH_80211_AUTH_ALG. And mac80211 >> > never actually supported _setting_ the WEP auth mechanism with >> > RESTRICTED/OPEN, only _getting_ that information. >> > >> > johannes >> > >> > >> >> Argh, is this the reason why compat-wireless(wireless-testing?) today >> doesn't quite work any more? >> NetworkManager no longer wants to work, with this message in syslog: >> >> localhost NetworkManager: <WARN> nm_device_wifi_disable_encryption(): >> error setting key for device wlan2: Invalid argument > > That specific call shouldn't cause a hard error. It's just advisory. > And really, I could just remove that call in NM entirely, since > wpa_supplicant does clear keys in the MLME disconnect method now. > > Dan I reverted that specific change (bf2c6a38af6095ee1116278f240ccb9c65c6337d cfg80211: implement wext key handling) and redo compat-wireless and it is working again. I suppose the important thing is to keep userland change in sync. Somehow NW is using those IOCTLs, at least on my system. FWIW, I am using the distro's NetworkManager-0.7.1-4.git20090414.fc10.x86_64 . Hin-Tak -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
