> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Sent: Friday, June 14, 2024 2:32 PM
> To: David Lin <yu-hao.lin@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> briannorris@xxxxxxxxxxxx; kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete
> Hsieh <tsung-hsien.hsieh@xxxxxxx>; Francesco Dolcini
> <francesco.dolcini@xxxxxxxxxxx>
> Subject: Re: [EXT] Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP
> mode
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Fri, Jun 14, 2024 at 02:06:45AM +0000, David Lin wrote:
> > > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > Sent: Wednesday, June 12, 2024 9:12 PM
> > > To: David Lin <yu-hao.lin@xxxxxxx>
> > > Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > briannorris@xxxxxxxxxxxx; kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx;
> > > Pete Hsieh <tsung-hsien.hsieh@xxxxxxx>; Francesco Dolcini
> > > <francesco.dolcini@xxxxxxxxxxx>
> > > Subject: [EXT] Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for
> > > AP mode
> > >
> > > Caution: This is an external email. Please take care when clicking
> > > links or opening attachments. When in doubt, report the message
> > > using the 'Report this email' button
> > >
> > >
> > > Hi David,
> > >
> > > On Thu, Apr 18, 2024 at 02:06:26PM +0800, David Lin wrote:
> > > > Add host based MLME to enable WPA3 functionalities in AP mode.
> > > > This feature required a firmware with the corresponding V2 Key API
> > > > support. The feature (WPA3) is currently enabled and verified only
> > > > on IW416. Also, verified no regression with change when host MLME
> > > > is disabled.
> > > >
> > > > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx>
> > > > Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> > > > ---
> > > >
> > >
> > > > diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > > > b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > > > index 491e36611909..073c665183b3 100644
> > > > --- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > > > +++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > > > @@ -72,6 +72,10 @@ int mwifiex_set_secure_params(struct
> > > mwifiex_private *priv,
> > > > bss_config->key_mgmt =
> > > KEY_MGMT_PSK;
> > > > }
> > > > break;
> > > > + case WLAN_AKM_SUITE_SAE:
> > > > + bss_config->protocol = PROTOCOL_WPA2;
> > > > + bss_config->key_mgmt = KEY_MGMT_SAE;
> > > > + break;
> > >
> > > Shouldn't this be |= PROTOCOL_WPA2 and |= KEY_MGMT_SAE?
> > > Clearing the other flags when SAE is enabled looks wrong to me.
> > >
> > > Sascha
> > >
> >
> > These fields are used for the configuration of FW, this is the correct setting.
>
> This is done in a loop iterating over the different AKM suites, with your patch
> this looks like this:
>
> for (i = 0; i < params->crypto.n_akm_suites; i++) {
> switch (params->crypto.akm_suites[i]) {
> case WLAN_AKM_SUITE_8021X:
> if (params->crypto.wpa_versions &
> NL80211_WPA_VERSION_1) {
> bss_config->protocol =
> PROTOCOL_WPA;
> bss_config->key_mgmt =
> KEY_MGMT_EAP;
> }
> if (params->crypto.wpa_versions &
> NL80211_WPA_VERSION_2) {
> bss_config->protocol |=
> PROTOCOL_WPA2;
> bss_config->key_mgmt =
> KEY_MGMT_EAP;
> }
> break;
> case WLAN_AKM_SUITE_PSK:
> if (params->crypto.wpa_versions &
> NL80211_WPA_VERSION_1) {
> bss_config->protocol =
> PROTOCOL_WPA;
> bss_config->key_mgmt =
> KEY_MGMT_PSK;
> }
> if (params->crypto.wpa_versions &
> NL80211_WPA_VERSION_2) {
> bss_config->protocol |=
> PROTOCOL_WPA2;
> bss_config->key_mgmt =
> KEY_MGMT_PSK;
> }
> break;
> case WLAN_AKM_SUITE_SAE:
> bss_config->protocol = PROTOCOL_WPA2;
> bss_config->key_mgmt = KEY_MGMT_SAE;
> break;
>
> default:
> break;
> }
> }
>
> It looks wrong to overwrite bss_config->protocol and bss_config->key_mgmt in
> each iteration of this loop. If that would be correct, you wouldn't need a loop
> at all, but could instead configure based on the last AKM suite entry.
>
> In my understanding the bits in bss_config->key_mgmt should be ored together
> depending on the possible AKM suites which is also what the downstream
> driver does.
>
> Sascha
>
> --
> Pengutronix e.K. |
> |
> Steuerwalder Str. 21 |
> http://www.pen/
> gutronix.de%2F&data=05%7C02%7Cyu-hao.lin%40nxp.com%7C7c90883e11414
> 5a307fa08dc8c3ba753%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> 7C638539435049441786%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&
> sdata=QSbX5IuEvP18tf0t6sMe8%2F4kuHo7IFEURWabdE4Cxcg%3D&reserved=0
> |
> 31137 Hildesheim, Germany | Phone:
> +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:
> +49-5121-206917-5555 |
For the configuration of FW, ored only happens for the same AKM suite.
David
