> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Sent: Wednesday, June 12, 2024 9:12 PM > To: David Lin <yu-hao.lin@xxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > briannorris@xxxxxxxxxxxx; kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete > Hsieh <tsung-hsien.hsieh@xxxxxxx>; Francesco Dolcini > <francesco.dolcini@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP mode > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > Hi David, > > On Thu, Apr 18, 2024 at 02:06:26PM +0800, David Lin wrote: > > Add host based MLME to enable WPA3 functionalities in AP mode. > > This feature required a firmware with the corresponding V2 Key API > > support. The feature (WPA3) is currently enabled and verified only on > > IW416. Also, verified no regression with change when host MLME is > > disabled. > > > > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx> > > Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > --- > > > > > diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > > b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > > index 491e36611909..073c665183b3 100644 > > --- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > > +++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > > @@ -72,6 +72,10 @@ int mwifiex_set_secure_params(struct > mwifiex_private *priv, > > bss_config->key_mgmt = > KEY_MGMT_PSK; > > } > > break; > > + case WLAN_AKM_SUITE_SAE: > > + bss_config->protocol = PROTOCOL_WPA2; > > + bss_config->key_mgmt = KEY_MGMT_SAE; > > + break; > > Shouldn't this be |= PROTOCOL_WPA2 and |= KEY_MGMT_SAE? > Clearing the other flags when SAE is enabled looks wrong to me. > > Sascha > These fields are used for the configuration of FW, this is the correct setting. David
