Hi David, On Thu, Apr 18, 2024 at 02:06:26PM +0800, David Lin wrote: > Add host based MLME to enable WPA3 functionalities in AP mode. > This feature required a firmware with the corresponding V2 Key API > support. The feature (WPA3) is currently enabled and verified only > on IW416. Also, verified no regression with change when host MLME > is disabled. > > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx> > Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > --- > > diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > index 491e36611909..073c665183b3 100644 > --- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > +++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c > @@ -72,6 +72,10 @@ int mwifiex_set_secure_params(struct mwifiex_private *priv, > bss_config->key_mgmt = KEY_MGMT_PSK; > } > break; > + case WLAN_AKM_SUITE_SAE: > + bss_config->protocol = PROTOCOL_WPA2; > + bss_config->key_mgmt = KEY_MGMT_SAE; > + break; Shouldn't this be |= PROTOCOL_WPA2 and |= KEY_MGMT_SAE? Clearing the other flags when SAE is enabled looks wrong to me. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
