Search Linux Wireless

Re: [PATCH 4/4] [v2] wifi: rtlwifi: simplify LED management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/13/23 11:31, Kalle Valo wrote:

Is there a reason why you are changing error messages to debug messages like here:

-		pr_err("switch case %#x not processed\n",
-		       pled->ledpin);
+		rtl_dbg(rtlpriv, COMP_ERR, DBG_LOUD,
+			"unknown LED pin %d\n", pin);

Well, this sounds to be more problem-specific rather than
generic "something unexpected in the switch statement".

The commit log mentions nothing about that.

It seems I have to write more detailed commit message.
Should I resend?

Dmitry




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux