Dmitry Antipov <dmantipov@xxxxxxxxx> writes:
> On 6/13/23 11:31, Kalle Valo wrote:
>
>> Is there a reason why you are changing error messages to debug messages like here:
>>
>> - pr_err("switch case %#x not processed\n",
>> - pled->ledpin);
>> + rtl_dbg(rtlpriv, COMP_ERR, DBG_LOUD,
>> + "unknown LED pin %d\n", pin);
>
> Well, this sounds to be more problem-specific rather than
> generic "something unexpected in the switch statement".
>
>> The commit log mentions nothing about that.
>
> It seems I have to write more detailed commit message.
> Should I resend?
We prefer one logical change per patch, so it's better to remove all the
pr_err() conversions and resend as v3. And let's just drop the pr_err()
conversions, rtlwifi is an old driver and we want to keep changes to
that driver to the minimum. rtlw8xxxu, rtw88 and rtw89 are the active
Realtek drivers.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
