Dmitry Antipov <dmantipov@xxxxxxxxx> wrote: > Introduce 'rtl_init_sw_leds()' to replace per-chip LED > initialization code (and so drop 'struct rtl_led' as no > longer used), drop 'init_sw_leds' and 'deinit_sw_leds' > fields from 'struct rtl_hal_ops', adjust related code. > > Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx> Is there a reason why you are changing error messages to debug messages like here: - pr_err("switch case %#x not processed\n", - pled->ledpin); + rtl_dbg(rtlpriv, COMP_ERR, DBG_LOUD, + "unknown LED pin %d\n", pin); The commit log mentions nothing about that. -- https://patchwork.kernel.org/project/linux-wireless/patch/20230608095051.116702-4-dmantipov@xxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches