Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > This flaw is detected by smatch: > drivers/net/wireless/realtek/rtw88/mac.c:748 __rtw_download_firmware() > warn: missing unwind goto? > > Though most things of dlfw_fail have been done by > download_firmware_end_flow() and wlan_cpu_enable(), an exception is that > download_firmware_end_flow() clear BIT_MCUFWDL_EN bit conditionally. > So, make this change to clear the bit. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Closes: https://lore.kernel.org/r/202306052310.OVhcUjZ3-lkp@xxxxxxxxx/ > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Patch applied to wireless-next.git, thanks. 91ccdbb94fea wifi: rtw88: add missing unwind goto for __rtw_download_firmware() -- https://patchwork.kernel.org/project/linux-wireless/patch/20230607012741.10353-1-pkshih@xxxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
