On Mon, 2008-11-03 at 00:40 -0800, Luis R. Rodriguez wrote: > On Mon, Nov 3, 2008 at 12:30 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Mon, 2008-11-03 at 00:26 -0800, Luis R. Rodriguez wrote: > > > >> >> What should we do with these rare failures then? > >> > > >> > print an error message? ignore them? try again? > >> > >> I'd prefer a simple error print than a WARN_ON(). > > > > Just so you don't get blamed on kerneloops.org? :) > > No because like I said a hw reset can fail and don't think software > should be blamed. Right now we do that. fyi ... We also have to deal with this in iwlwifi now because the driver chooses not to send commands to the hardware if rfkill is enabled. If this is the case (command needs to go to hw, but rfkill is enabled) then we currently return an error ... triggering this warning. We cannot return success in this case and queuing the command for later does not make sense. Reinette -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
