On Sun, 2008-11-02 at 23:51 -0800, Luis R. Rodriguez wrote: > On Sun, Nov 2, 2008 at 11:34 PM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > On Sun, 2008-11-02 at 23:29 -0800, Luis R. Rodriguez wrote: > > > >> >> Not sure I agree with the WARN_ON() if the driver's mac80211 config() > >> >> callback fails. In our case when we tune to a different channel we > >> >> have to clear any DMA operations first and then we reset the chip. > >> >> Reseting the chip can fail for whatever strange hw issue cases. The > >> >> patch fixes the complaint but is the complaint sane? > >> > > >> > What's mac80211 to do when it fails? > >> > >> How about a shiny new nl80211 event? > > > > And wtf would userspace do? > > If multiple configuration attempts fail perhaps stop trying, and > inform the user? But you're saying it's "normal" to get this failure, so wouldn't it always do that sooner or later and always say your hw is broken? Also, that's a bad thing to do in userspace, imho. Why can it fail here anyway? hw borked is one obvious case, but it shouldn't happen enough for this to be a problem yet. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
