2008/11/1 Luis R. Rodriguez <mcgrof@xxxxxxxxx>: > On Wed, Oct 29, 2008 at 12:19 PM, Tim Gardner <tcanonical@xxxxxxx> wrote: >> This commit 'ath5k: Update interrupt masking code' causes stalls under >> load when built using compat-wireless on 2.6.27. There is no output from >> dmesg, but it occasionally recovers and moves a few more packets before >> stalling again. Luis suggested reverting >> eb9d4e8399181357cb6f6625ba7f849987432c6c which I did. Now it appears to >> work normally. >> >> I also think this patch should be broken into multiple pieces. There >> appear to be at least 3 functional changes addressed in this single patch. > > Agreed, I just tested with the latest wireless-testing and the issue > is still present. I reviewed the commit but its a big too large to pin > point the exact issue, my AR5414 goes up but then quickly becomes > unusable. Nick how about we revert this and you can then split this up > into a good number of patches to make the review easier and also to be > able to pin point the exact issue better? > > The SHA1 remains the same but just in case the title of the patch is: > > ath5k: Update interrupt masking code > > With it reverted I'm cruising and can ditch MadWifi completely, which > is the idea. > > Luis > Code doesn't introduce many functional changes, we can't eg. patch only the code that reads interrupt status and not the code that masks interrupts etc. Also if you compare the code with legacy-hal you'll see that legacy-hal does mostly the same (we just handle all cases and have better abstraction on ath5k.h + the RXNOFRM/TXNOFRM trick) + most of the code is about interrupts we don't enable anyway. Anyway i think i found the problem (on base.c we don't unmask TXDESC on PIMR), i'll do a few more tests and come back to you asap ;-) -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
