2008/11/2 Nick Kossifidis <mickflemm@xxxxxxxxx>:
> 2008/11/1 Luis R. Rodriguez <mcgrof@xxxxxxxxx>:
>> On Wed, Oct 29, 2008 at 12:19 PM, Tim Gardner <tcanonical@xxxxxxx> wrote:
>>> This commit 'ath5k: Update interrupt masking code' causes stalls under
>>> load when built using compat-wireless on 2.6.27. There is no output from
>>> dmesg, but it occasionally recovers and moves a few more packets before
>>> stalling again. Luis suggested reverting
>>> eb9d4e8399181357cb6f6625ba7f849987432c6c which I did. Now it appears to
>>> work normally.
>>>
>>> I also think this patch should be broken into multiple pieces. There
>>> appear to be at least 3 functional changes addressed in this single patch.
>>
>> Agreed, I just tested with the latest wireless-testing and the issue
>> is still present. I reviewed the commit but its a big too large to pin
>> point the exact issue, my AR5414 goes up but then quickly becomes
>> unusable. Nick how about we revert this and you can then split this up
>> into a good number of patches to make the review easier and also to be
>> able to pin point the exact issue better?
>>
>> The SHA1 remains the same but just in case the title of the patch is:
>>
>> ath5k: Update interrupt masking code
>>
>> With it reverted I'm cruising and can ditch MadWifi completely, which
>> is the idea.
>>
>> Luis
>>
>
Can you test the attached patch ?
It works for me (tested on a AR5413)...
makis linux # iperf -s
------------------------------------------------------------
Server listening on TCP port 5001
TCP window size: 85.3 KByte (default)
------------------------------------------------------------
[ 4] local 192.168.1.104 port 5001 connected with 192.168.1.10 port 43192
[ ID] Interval Transfer Bandwidth
[ 4] 0.0-10.6 sec 21.8 MBytes 17.2 Mbits/sec
makis linux # iwconfig
lo no wireless extensions.
eth0 no wireless extensions.
wmaster0 no wireless extensions.
wlan1 IEEE 802.11abg ESSID:"MickFlemm"
Mode:Managed Frequency:2.437 GHz Access Point: 00:1D:7E:AE:95:44
Bit Rate=24 Mb/s Tx-Power=20 dBm
Retry min limit:7 RTS thr:off Fragment thr=2352 B
Encryption key:off
Power Management:off
Link Quality=97/100 Signal level:-60 dBm Noise level=-94 dBm
Rx invalid nwid:0 Rx invalid crypt:0 Rx invalid frag:0
Tx excessive retries:0 Invalid misc:0 Missed beacon:0
--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index 5ef8cc4..f5f46fe 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -2219,9 +2219,9 @@ ath5k_init(struct ath5k_softc *sc, bool is_resume)
*/
sc->curchan = sc->hw->conf.channel;
sc->curband = &sc->sbands[sc->curchan->band];
- sc->imask = AR5K_INT_RXOK | AR5K_INT_TXOK | AR5K_INT_RXEOL |
- AR5K_INT_RXORN | AR5K_INT_FATAL | AR5K_INT_GLOBAL |
- AR5K_INT_MIB;
+ sc->imask = AR5K_INT_RXOK | AR5K_INT_RXERR | AR5K_INT_RXEOL |
+ AR5K_INT_RXORN | AR5K_INT_TXDESC | AR5K_INT_TXEOL |
+ AR5K_INT_FATAL | AR5K_INT_GLOBAL | AR5K_INT_MIB;
ret = ath5k_reset(sc, false, false);
if (ret)
goto done;
