On 10/19/2018 12:02 AM, Johannes Berg wrote: > >>>> Do you mean we should be doing the work from the cfg context? >>>> Note that this is called cfg80211_ops.set_wiphy_params(), and involves >>>> locking mutexes, packing the wids, bus operations, and waiting for the >>>> device to respond. >>> >>> That *should* be fine - how long do you expect that to take? >>> >> >> It depends on the IO bus used (SPI/SDIO), clock speed.. etc >> It would also vary according to the data packets being transferred >> with the device. >> If there's heavy data transfer, configuration packets would take >> longer to be sent, and for their response to be received. > > How much time do you think you're looking at? > > I'd argue for trying it though as it makes the code MUCH simpler. I totally agree that it will be simpler to do the work directly from the cfg context rather than scheduling it. On a cortex A5 MPU and SPI bus running on 48Mhz, this takes 20ms in the idle case, and 100 to 300ms in case of data being transferred in parallel. Thanks, Adham
