> Agree. parameter validation can be done before scheduling the work, > and hence appropriate error can be returned to caller . > If I got your point correctly, you are referring to the lines that > stores the parameters into the hif_drv->cfg_values. Well, I was actually thinking that I'm not even sure why you schedule work at all! > Instead of packing the parameters in host structures like struct > add_sta_param, then repacking it in the device format, it can use > struct station_parameters and pack them directly into the device > format Makes sense. Also note my other email on how there should be structs involved, rather than open-coded WID entry lists. johannes
