On Fri, 19 Oct 2018 at 08:48, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Fri, 2018-10-19 at 04:37 +0200, Andrew Zaborowski wrote: > > Let userspace learn about iftype changes by sending an > > NL80211_CMD_NEW_INTERFACE when handling a NL80211_CMD_SET_INTERFACE > > command. There seems to be no other place where the iftype can change: > > nl80211_set_interface is the only caller of cfg80211_change_iface which > > is the only caller of ops->change_virtual_intf. > > Why not use SET_INTERFACE? I think I'd be more comfortable with that, > since it's not really used now and existing userspace might do weird > things with NEW_INTERFACE? True, let's use SET_INTERFACE then. Best regards