Search Linux Wireless

Re: [PATCH v3] cfg80211: Reorder wiphy_register/unregister() notifications relevantly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

>+	cfg80211_debugfs_rdev_add(rdev);
>+	rtnl_unlock();
I'm not convinced that it's safe to drop the rtnl here, when we only
later set wiphy.registered = true.

As is, the wiphy would end up on the list, but not registered - yet in
this period it would be reachable for example for nl80211 commands in
the unregistered state. This seems wrong.

Ok, I counted on the fact the device is not yet advertized as being ready (the NEW_WIPHY below).
Will see how to avoid this early unlock.

Additionally, maybe add a brief note regarding the second part of the
patch (checking registered in unregister) to the commit log?

Sure.

Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux