On Tue, 2014-08-19 at 12:35 +0300, Tomasz Bursztyka wrote: > + cfg80211_debugfs_rdev_add(rdev); > + rtnl_unlock(); I'm not convinced that it's safe to drop the rtnl here, when we only later set wiphy.registered = true. As is, the wiphy would end up on the list, but not registered - yet in this period it would be reachable for example for nl80211 commands in the unregistered state. This seems wrong. Additionally, maybe add a brief note regarding the second part of the patch (checking registered in unregister) to the commit log? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html