On 29 August 2014 13:05, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2014-08-18 at 15:07 +0200, Michal Kazior wrote: [...] >> Another way to fix this would probably be to change >> ieee80211_remove_interfaces() to remove all interfaces one-by-one >> (instead of in bulk). It seems iflist_mtx can be temporarily released >> while iterating over interfaces for the sake of calling >> unregister_netdevice() for each one because RTNL is held all the time >> guaranteeing no new interfaces are added in the meantime. I'm not sure >> if it's perfectly safe to replace unregister_netdevice_many() just >> like that though. I can look more into it. > > Well, it's safe, but it's more efficient to call the _many() because > otherwise you require rcu_synchronize() for each one. > > I'll apply this, to -next for now, later we can decide if we want to > send it to stable or so? Thanks. As far as I'm aware the splat was harmless so I'm unsure if it qualifies for stable. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
