Search Linux Wireless

Re: is L1 really disabled in iwlwifi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[+cc Wei-Yi, Matthew]

On Tue, Apr 30, 2013 at 4:57 AM, Emmanuel Grumbach <egrumbach@xxxxxxxxx> wrote:
>>
>>> Sorry, I haven't had a chance to look at this yet.  Can you please
>>> attach the *complete* dmesg and lspci output, not just the parts that
>>> mention iwlwifi?  Some of this depends on other PCI core stuff, like
>>> what happened with the _OSC evaluation when we discovered the PCI host
>>> bridge.
>>>
>>
>> Here is the info you wanted. Same config file as before.
>> Note that I now have two WiFi NICs connected.
>
> Any chance you'll find time for me? :-)

Thanks for reminding me again; I had forgotten all about this.  I
opened https://bugzilla.kernel.org/show_bug.cgi?id=57331 and attached
your logs there.

Synopsis for Wei-Yi and Matthew: after 1a7123cdd9, iwlwifi calls
pci_disable_link_state() to prevent the link from entering L1, which
avoided "inexplicable PCIe disconnects."  pci_disable_link_state() has
always been a no-op when aspm_disabled is set, and we set it whenever
the BIOS declines to give us _OSC control.

In Emmanuel's case, we don't get _OSC control, so
pci_disable_link_state() does nothing.

I'm not convinced iwlwifi really needs to disable the link power
management states in the first place -- the 1a7123cdd9 changelog isn't
very convincing, and I'm not aware of any reported issues even though
we're actually leaving them enabled in many cases.

More generally, I don't think the pci_disable_link_state() interface
is very useful because it often doesn't do what it claims, and the
caller has no indication.

Wei-Yi, can you tell us anything about whether iwlwifi really needs to
disable link power management?

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux