Search Linux Wireless

RE: Memory leak in mwifiex_cfg80211_scan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,

> It makes me uneasy that you are prepping the driver to have this timer
> still running after mwifiex_close() is called. 

When mwifiex_close() is called a scan command can be still in processing.
We have to wait for the scan command response from firmware before the remaining scan commands can be cleaned up. Once the command response is back the scan timer gets called to cleanup the scan.

> Anyway, if you do want to go this route, 
> I think there is no need to add is_ndo_stop. 

We will need a flag to indicate that the current scan request is being aborted.
'is_ndo_stop' is not a good name though. In attached revised patch, it's been renamed to 'scan_aborting'.

> You should be able to query the net layer for its state. Maybe
> netif_running() will do the trick.

The netif_running state may not be accurate as the use can bring the interface up again shortly.
Even if user does 'ifconfig eth0 up' again, we still need to continue the scan abort processing.

> 
> I'll await your comments on that before testing.

Please test the revision attached with this e-mail.

Thanks,
Bing

> 
> Thanks
> Daniel

Attachment: v3_0001-mwifiex-remove-global-user_scan_cfg-variable.patch
Description: v3_0001-mwifiex-remove-global-user_scan_cfg-variable.patch


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux