>> >> Anyway - I think I will just remove this pci_disable_link_state call >> and hopefully, it will stay long enough in linux-next so that people >> will report issues before it get into linux. >> I don't like leaving that code if it doesn't do anything. > > I think we broke at least some cases of pci_disable_link_state() a > while back. I'd like to fix it rather than just removing calls to it. > > Can someone collect a complete dmesg log and "lspci -vv" output? > I will. But I am on vacation right now and my linux box is not accessible right now... In any case, what you'll see is that ASPM is enabled (L1 enabled with or without driver). We are also seeing some really weird stuff (which I can't reproduce of course) like HW becoming not accessible, I guess it would be worth trying to *really* disable L1. I can tweak that in the code of the driver and tell the NIC that L1 is disabled. /* Disable L1-Active */ iwl_set_bits_prph(trans, APMG_PCIDEV_STT_REG, APMG_PCIDEV_STT_VAL_L1_ACT_DIS); Do you have an idea about *when* did pci_disable_link_state() break? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
