On Fri, Jan 25, 2008 at 01:56:15PM -0800, Linus Torvalds wrote: > > > On Fri, 25 Jan 2008, John W. Linville wrote: > > > > Anyway, this is mostly just so we can scope the driver change required > > in absence of a firmware change. Persumably the changes required if > > we were to put such code in mac80211 would be similar. > > Make this conditional on archictures that need it, please. > > And why is it suddenly smart to do this in three drivers rather than one > upper layer? Two drivers, FWIW... :-) Given that we don't have a CONFIG_MUST_ALIGN at present, I'm not sure it is worth adding one for either an iwlwifi fix or a mac80211 one. Or are there other issues that might be resolved or aided by such a definition? It doesn't seem to have been needed so far. Maybe it would be easier to add a CONFIG_MAC80211_ALIGN_PAYLOAD option around some code in mac80211 to fix-up alignments? Then users of alignment-sensitive arches could turn-on that option, and the rest of us would leave it off. Another (non-exclusive) option would be to put CONFIG_MAC80211_DEBUG around the alignment warning so that most people would never see it. Thoughts? I'm just looking for a resolution... :-) John -- John W. Linville linville@xxxxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
