On Friday 25 January 2008 19:22:13 Linus Torvalds wrote: > > On Fri, 25 Jan 2008, Linus Torvalds wrote: > > > > But complaining about a vendor who does a good job technically, for > > non-technical reasons, I really don't see that as being fine. > > Side note: I also think the wireless parts here are doing things wrong. > > Why _would_ you care about alignment? We used to have issues like that in > the normal networking code, and it was a mistake there too. Why isn't the > wireless stack just extracting the header explicitly, or using > "get_unaligned()" like regular networking? The problem is _not_ the wireless header access, but the alignment of the embedded protocol stack, if the header does not have a size aligned to 4. Do we want to clutter the whole networking stack below wireless with get_unaligned() or attribute(packed) or something like that? -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
