On Fri, Nov 10, 2023 at 08:58:57PM +0100, Krzysztof Kozlowski wrote: > I am repeating myself... but I don't know how to put it other way. I did > not ask you to rewrite your driver. I asked to drop the change to > bindings, because it is entirely pointless. > > Drop this change, only this. No need to rewrite drivers, they stay the same. Dropping this change (I'm assuming you are referring to the hunk adding include/dt-bindings/reset/mt7988-resets.h) and also not adding that header file using a seperate commit means that there won't be a header defining the reset names. The result would be having to numerically reference the specific resets in the device tree. This is, of course, possible, but I don't understand what the advantage would be.