On 10/11/2023 16:15, Krzysztof Kozlowski wrote: >>>> So adding the file to include/dt-bindings/reset/ should go into a >>>> seperate patch? Because including it with the driver itself gave me >>>> a checkpath warning telling me that dt-bindings should go seperate, >>>> which is why I included it with the binding docs. >>> >>> No, I said the hunk should be dropped. Removed. >> >> I guess we are somehow misunderstanding each other. >> Lets go with an example. I can put the header into a commit of its own, >> just like commit >> 5794dda109fc8 dt-bindings: reset: mt7986: Add reset-controller header file >> https://lore.kernel.org/r/20220105100456.7126-2-sam.shih@xxxxxxxxxxxx >> >> Would that be acceptable? And if not, why? > > ...this question. > > Again, whether this is separate patch - it is still hunk which I think > should be removed. I gave the reason "why" in this mail thread and in > multiple other discussions. I gave you clear reasoning 7 hours ago: https://lore.kernel.org/all/59629ec1-cc0c-4c5a-87cc-ea30d64ec191@xxxxxxxxxx/ to which you did not respond. Best regards, Krzysztof
