On 10/11/2023 15:17, Daniel Golle wrote: > On Fri, Nov 10, 2023 at 12:56:18PM +0100, AngeloGioacchino Del Regno wrote: >> Il 10/11/23 01:30, Daniel Golle ha scritto: >>> Add binding description for mediatek,mt7988-wdt. >>> >>> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> >>> --- >>> .../bindings/watchdog/mediatek,mtk-wdt.yaml | 1 + >>> include/dt-bindings/reset/mediatek,mt7988-resets.h | 12 ++++++++++++ >>> 2 files changed, 13 insertions(+) >>> create mode 100644 include/dt-bindings/reset/mediatek,mt7988-resets.h >>> >>> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >>> index cc502838bc398..8d2520241e37f 100644 >>> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >>> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml >>> @@ -25,6 +25,7 @@ properties: >>> - mediatek,mt6735-wdt >>> - mediatek,mt6795-wdt >>> - mediatek,mt7986-wdt >>> + - mediatek,mt7988-wdt >>> - mediatek,mt8183-wdt >>> - mediatek,mt8186-wdt >>> - mediatek,mt8188-wdt >>> diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h >>> new file mode 100644 >>> index 0000000000000..fa7c937505e08 >>> --- /dev/null >>> +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h >>> @@ -0,0 +1,12 @@ >>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ >>> + >>> +/* TOPRGU resets */ >> >> The first reset is zero, the second reset is one. >> >> Where's the zero'th reset? :-) > > Currently the reset numbers represent the corresponding bit positions in > the toprgu register, as this is how the mtk-wdt driver is organized. > > So there is probably something at bit 0, and also at bit 3~11 and > maybe also 17~23, but it's unknown and may be added later once known > and/or needed. There is no need to put register bits, which are not used by the driver, in the bindings. Best regards, Krzysztof
