On Thu, May 03, 2007 at 02:20:32PM +1000, Rusty Russell wrote: >On Thu, 2007-05-03 at 11:57 +0800, WANG Cong wrote: >> On Thu, May 03, 2007 at 09:00:48AM +1000, Rusty Russell wrote: >> > Thanks for the patch. This omission (in several places) was >> >deliberate. We can't really do anything sensible if the user unmapped >> >the page. I assume you saw a gcc warning from this code? >> >> Yes. In fact, I got two warnings, another one is in drivers/lguest/hypercalls.c. >> >> If I understand you correctly, you mean we can do nothing useful to fix it? > >We can, but we can ignore those warnings for the moment; they're >harmless. OK. > >> I have sent a mail which described the errors I got when comipling >> Documentation/lguest/lguest.c. But it seems that you didn't receive it >> (it didn't appear in lkml.org neither!). > >Hmm, no, I didn't get it here either 8( > >> It is that, I have already made my .config as you suggested, but I >> still can't compile Documentation/lguest/lguest.c, errors are: >> >> lguest.c: In function 'add_to_bridge': >> lguest.c:779: error: 'SIOCBRADDIF' undeclared (first use in this function) >> lguest.c:779: error: (Each undeclared identifier is reported only once >> lguest.c:779: error: for each function it appears in.) > >Ah, perhaps older libc headers? Can you try adding this to the top of >Documentation/lguest/lguest.c after the #define BRIDGE_PFX "bridge:" > >#ifndef SIOCBRADDIF >#define SIOCBRADDIF 0x89a2 /* add interface to bridge */ >#endif > >Thanks, >Rusty. Yes, it works. Thanks very much for your pointing. I have already found you also forgot some checking in this user-space code. I will fix them soon. ;) Regards. WANG Cong _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
