On Thu, 2007-05-03 at 03:33 +0800, WANG Cong wrote: > Hi Rusty! > > I found you forgot to check the return value of copy_from_user, and > here is the fix for drivers/lguest/interrupts_and_traps.c. > > Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> Hi Wang! Thanks for the patch. This omission (in several places) was deliberate. We can't really do anything sensible if the user unmapped the page. I assume you saw a gcc warning from this code? We could also use lgread() in these places which does this check and kills the guest if something goes wrong. I'll check the benchmarks to make sure the (slight) extra overhead doesn't cause a regression... Thanks! Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
