Hi Rusty! I found you forgot to check the return value of copy_from_user, and here is the fix for drivers/lguest/interrupts_and_traps.c. Signed-off-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> --- --- linux-2.6.21-rc7-mm2/drivers/lguest/interrupts_and_traps.c.orig 2007-05-03 03:10:44.000000000 +0800 +++ linux-2.6.21-rc7-mm2/drivers/lguest/interrupts_and_traps.c 2007-05-03 03:11:42.000000000 +0800 @@ -75,7 +75,8 @@ void maybe_do_interrupt(struct lguest *l set_bit(0, lg->irqs_pending); /* Mask out any interrupts they have blocked. */ - copy_from_user(&blk, lg->lguest_data->blocked_interrupts, sizeof(blk)); + if (copy_from_user(&blk, lg->lguest_data->blocked_interrupts, sizeof(blk))) + return; bitmap_andnot(blk, lg->irqs_pending, blk, LGUEST_IRQS); irq = find_first_bit(blk, LGUEST_IRQS); _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
